Add icu75 for NodeJS and ICU4C execution #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL. I'd love to get this checked in soon. |
echeran
approved these changes
May 23, 2024
sffc
approved these changes
May 24, 2024
Comment on lines
1
to
29
| /* Generate listformat test data with the following dimensions: | ||
|
|
||
| 1. locale | ||
| 2. type (conjunction, disjunction, unit) | ||
| 3. style (long, short, narrow) | ||
| */ | ||
|
|
||
| // Set up Node version to generate data specific to ICU/CLDR version | ||
| // e.g., `nvm install 21.6.0;nvm use 21.6.0` (ICU 74) | ||
|
|
||
| const fs = require('node:fs'); | ||
|
|
||
| const debug = false; | ||
|
|
||
| const locales = ['und', | ||
| 'en-US', 'zh-TW', 'pt', 'vi', 'el', 'mt-MT', 'ru', 'en-GB', | ||
| 'bn', 'ar','mr', 'zu']; | ||
|
|
||
| const types = ['conjunction', 'disjunction', 'unit']; | ||
|
|
||
| const styles = ['long', 'short', 'narrow']; | ||
|
|
||
| const lists = [ | ||
| [], | ||
| ['cat'], | ||
| ['dog', 'cat'], | ||
| ['fish', 'mouse', 'parakeet'], | ||
| ['3 weeks', '2 days', '3 hours', '25 minutes'] | ||
| ]; |
There was a problem hiding this comment.
Double-check this file; it looks like it generates list data, but:
- It is named
plural_rules_gen.js - It is in a PR that should be a clean ICU 75 update
There was a problem hiding this comment.
Removed this generator. Thx for catching this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses ICU75.1 and CLDR 45 data. Now there will be 7 versions of NodeJS in the data.