-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-17626 Fix day periods for Sicilian (scn), and provide initial data. #3710
base: main
Are you sure you want to change the base?
Conversation
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
thanks! The translations should be provided through the Survey Tool which is open now (as of yesterday). If you don't have an account to contribute under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM but I'd drop the scn.xml changes - should be in surveytool
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
Yup, done! It'd be extra nice to have this in v46, since the AM/PM issue is the only missing bit to have Basic coverage. Thank you for considering! |
Great, if we didn’t discuss this already go ahead and put data in even if
you don’t have your organization account yet, we can transfer your account
over later
El El jue, may 16, 2024 a la(s) 4:29 p.m., David Paleino <
***@***.***> escribió:
… Generally LGTM but I'd drop the scn.xml changes - should be in surveytool
Yup, done!
I have an account (actually, I'm also waiting for the creation of an org
account, but that's another issue), but I thought it would make sense to
also commit some defaults.
It'd be extra nice to have this in v46, since the AM/PM issue is the only
missing bit to have Basic coverage.
Thank you for considering!
—
Reply to this email directly, view it on GitHub
<#3710 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGQZM2MYP5D2JLNKJME4P3ZCUQLRAVCNFSM6AAAAABHR6KRVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWGIZDCNRTGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Yes, I'm doing that already, it's just that each and every time I checked
the survey tool was closed... this time I could manage to remember to check
and also find free time while it was open 😀
Thank you for reviewing the patch!
David
(btw the issue regarding the org account is from 2020 🤣)
Il Ven 17 Mag 2024, 01:16 Steven R. Loomis ***@***.***> ha
scritto:
… Great, if we didn’t discuss this already go ahead and put data in even if
you don’t have your organization account yet, we can transfer your account
over later
El El jue, may 16, 2024 a la(s) 4:29 p.m., David Paleino <
***@***.***> escribió:
> Generally LGTM but I'd drop the scn.xml changes - should be in
surveytool
>
> Yup, done!
> I have an account (actually, I'm also waiting for the creation of an org
> account, but that's another issue), but I thought it would make sense to
> also commit some defaults.
>
> It'd be extra nice to have this in v46, since the AM/PM issue is the
only
> missing bit to have Basic coverage.
>
> Thank you for considering!
>
> —
> Reply to this email directly, view it on GitHub
> <#3710 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAGQZM2MYP5D2JLNKJME4P3ZCUQLRAVCNFSM6AAAAABHR6KRVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWGIZDCNRTGI>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#3710 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAJ27JG7JNBVF76YQVW55LZCU44LAVCNFSM6AAAAABHR6KRVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWGM3DANRVGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
CLDR-17626
ALLOW_MANY_COMMITS=true