Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17626 Fix day periods for Sicilian (scn), and provide initial data. #3710

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dpaleino
Copy link

@dpaleino dpaleino commented May 11, 2024

CLDR-17626

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@CLAassistant
Copy link

CLAassistant commented May 11, 2024

CLA assistant check
All committers have signed the CLA.

@dpaleino dpaleino changed the title Fix day periods for Sicilian (scn), and provide initial data. CLDR-17626 Fix day periods for Sicilian (scn), and provide initial data. May 11, 2024
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295
Copy link
Member

srl295 commented May 16, 2024

thanks! The translations should be provided through the Survey Tool which is open now (as of yesterday). If you don't have an account to contribute under scn you can file for one at https://corp.unicode.org/reporting/cldr-id.html

Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM but I'd drop the scn.xml changes - should be in surveytool

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • common/main/scn.xml is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@dpaleino
Copy link
Author

Generally LGTM but I'd drop the scn.xml changes - should be in surveytool

Yup, done!
I have an account (actually, I'm also waiting for the creation of an org account, but that's another issue), but I thought it would make sense to also commit some defaults.

It'd be extra nice to have this in v46, since the AM/PM issue is the only missing bit to have Basic coverage.

Thank you for considering!

@srl295
Copy link
Member

srl295 commented May 16, 2024 via email

@dpaleino
Copy link
Author

dpaleino commented May 17, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants