CLDR-16499 require a CLA for contributions #3653
Conversation
- new claSigned bit must be true to allow writing - store CLAs as JSON blobs in user prefs - API to read/update/revoke CLA - static list of signatory orgs - new menu item for CLA Other improvements/ - store JSON in the user settings data - load .md file via webpack - display markdown using marked (same as the error/wikimedia abstracts) - fix the client so that it doesn't hit the OpenAPI spec multiple times
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
@btangmu I'll fix this so that the unit tests don't need to sign a CLA ! I'm just wondering if for local testing we want a switch that auto-signs the CLA? But then again, if you create a vetter in a signing org such as Apple Google Microsoft then it won't ask for a CLA. |
|
@btangmu i think this could get any feedback from you if you want to provide it, knowing we still need to review the text and the overall process. But let me know if you see any structural issues. |
| @@ -8,6 +8,7 @@ | |||
| <li> | |||
| <ul> | |||
| <li><a href="#account///">Account Settings</a></li> | |||
| <!-- <li><a href="#cla///">Sign CLA</a></li> --> | |||
There was a problem hiding this comment.
what's this? better not to add commented-out code?
| <script setup> | ||
| import * as cldrStatus from "../esm/cldrStatus.mjs"; | ||
| import * as cldrClient from "../esm/cldrClient.mjs"; | ||
| import * as cldrNotify from "../esm/cldrNotify.mjs"; |
There was a problem hiding this comment.
these imports should be alphabetized, better than random order
| display: "flex", | ||
| }; | ||
|
|
||
| async function loadData() { |
There was a problem hiding this comment.
for separation of concerns, my preference is that Vue components shouldn't include client/server code
I realize you may not agree with that, and I don't know if I could persuade you, so I won't insist on it :-)
There was a problem hiding this comment.
This is a draft PR for the purpose of a UX / legal review. I appreciate the comments and will do them to refactor before merge. I do plan to merge with everything switched off so we can un mothball it later.
CLDR-16499
ALLOW_MANY_COMMITS=true