Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17519 Move English data of subdivisions to root #3616

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

garywade
Copy link

@garywade garywade commented Apr 5, 2024

Moved the contents of localeDisplayNames in en.xml of subdivisions to root.xml so all locales will have fallback data.

CLDR-17519

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@CLAassistant
Copy link

CLAassistant commented Apr 5, 2024

CLA assistant check
All committers have signed the CLA.

@pedberg-icu
Copy link
Contributor

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@garywade @DraganBesevic @richgillam Gary, Apple already has a CLA with Unicode that covers the contributions of all Apple employees, so do not sign an individual CLA. Your name just needs to be added to the list of Apple contributors. Dragan or Rich, I think you need to e-mail Steven or Markus to get Rich added to the list of people covered by the Apple CLA.

@macchiati
Copy link
Member

macchiati commented Apr 6, 2024 via email

@garywade garywade force-pushed the CLDR-17519-move-en-subdivisions-to-root branch from 3b9db1c to 2d9826e Compare April 8, 2024 23:54
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • tools/cldr-code/src/main/java/org/unicode/cldr/test/CheckDisplayCollisions.java is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@macchiati
Copy link
Member

macchiati commented Apr 9, 2024 via email

Moved the contents of localeDisplayNames in en.xml of subdivisions to root.xml so all locales will have fallback data.  Also removed subdivisions from the CheckDisplayCollisions test since there will be lots of expected and allowed collisions within it and across territories.
@garywade garywade force-pushed the CLDR-17519-move-en-subdivisions-to-root branch from 2d9826e to 4e6282a Compare April 9, 2024 17:50
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • tools/cldr-code/src/main/java/org/unicode/cldr/test/CheckDisplayCollisions.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@garywade
Copy link
Author

garywade commented Apr 9, 2024

I added to the design meeting agenda. We talked a bit about subdivisions at this week's meeting, but with no conclusion; it would be good if you could join a future meeting, Gary.

@macchiati I didn't catch this early enough to join on Monday. Would it help to join the Wednesday morning CLDR-TC meeting?

@macchiati
Copy link
Member

macchiati commented Apr 9, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants