-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-17519 Move English data of subdivisions to root #3616
base: main
Are you sure you want to change the base?
CLDR-17519 Move English data of subdivisions to root #3616
Conversation
@garywade @DraganBesevic @richgillam Gary, Apple already has a CLA with Unicode that covers the contributions of all Apple employees, so do not sign an individual CLA. Your name just needs to be added to the list of Apple contributors. Dragan or Rich, I think you need to e-mail Steven or Markus to get Rich added to the list of people covered by the Apple CLA. |
Moving the subdivision codes to root should be put on the Design group
agenda.
For other data we have tried to specifically make the root locale data has
neutral as possible so that translators don't simply use the English when
it's inappropriate.
…On Fri, Apr 5, 2024, 20:13 Peter Edberg ***@***.***> wrote:
Thank you for your submission! We really appreciate it. Like many open
source projects, we ask that you sign our Contributor License Agreement
<https://cla-assistant.io/unicode-org/cldr?pullRequest=3616> before we
can accept your contribution.
@garywade <https://github.com/garywade> @DraganBesevic
<https://github.com/DraganBesevic> @richgillam
<https://github.com/richgillam> Gary, Apple already has a CLA with
Unicode that covers the contributions of all Apple employees, so do not
sign an individual CLA. Your name just needs to be added to the list of
Apple contributors. Dragan or Rich, I think you need to e-mail Steven or
Markus to get Rich added to the list of people covered by the Apple CLA.
—
Reply to this email directly, view it on GitHub
<#3616 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMBGIVRKH3QY5IFGITLY35K4NAVCNFSM6AAAAABFZ27JT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQHA4DKNRYG4>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
3b9db1c
to
2d9826e
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
I added to the design meeting agenda. We talked a bit about subdivisions at
this week's meeting, but with no conclusion; it would be good if you could
join a future meeting, Gary.
…On Mon, Apr 8, 2024 at 4:54 PM jira-pull-request-webhook[bot] < ***@***.***> wrote:
Notice: the branch changed across the force-push!
- tools/cldr-code/src/main/java/org/unicode/cldr/test/CheckDisplayCollisions.java
is now changed in the branch
View Diff Across Force-Push
<https://github.com/unicode-org/cldr/compare/unicode-org:3b9db1c..unicode-org:2d9826e>
~ Your Friendly Jira-GitHub PR Checker Bot
—
Reply to this email directly, view it on GitHub
<#3616 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMGQUYLEHTEMDUDFKHTY4MU45AVCNFSM6AAAAABFZ27JT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBTHA4DQOBSGU>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Moved the contents of localeDisplayNames in en.xml of subdivisions to root.xml so all locales will have fallback data. Also removed subdivisions from the CheckDisplayCollisions test since there will be lots of expected and allowed collisions within it and across territories.
2d9826e
to
4e6282a
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
@macchiati I didn't catch this early enough to join on Monday. Would it help to join the Wednesday morning CLDR-TC meeting? |
We won't discuss in the main meeting until we have a recommendation from
the design team. So the design meeting is the right one to attend. There's
no real urgency because the current release is closed for new additions.
…On Tue, Apr 9, 2024, 14:30 garywade ***@***.***> wrote:
I added to the design meeting agenda. We talked a bit about subdivisions
at this week's meeting, but with no conclusion; it would be good if you
could join a future meeting, Gary.
@macchiati <https://github.com/macchiati> I didn't catch this early
enough to join on Monday. Would it help to join the Wednesday morning
CLDR-TC meeting?
—
Reply to this email directly, view it on GitHub
<#3616 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMEF42HKYAL6PML2BG3Y4RMY5AVCNFSM6AAAAABFZ27JT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBWGA4DGMBYGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Moved the contents of localeDisplayNames in en.xml of subdivisions to root.xml so all locales will have fallback data.
CLDR-17519
ALLOW_MANY_COMMITS=true