Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow html atts in htmlmap #26

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Allow html atts in htmlmap #26

wants to merge 5 commits into from

Conversation

abelpz
Copy link
Member

@abelpz abelpz commented Apr 6, 2023 •
edited

  1. Adds support to include html attributes in htmlMap.
  2. Updates version of epitelete which includes the new savePerf and canSavePerf methods.
  3. Turns off cloning in epitelete methods, so no unnecessary deep cloning is done.

@abelpz abelpz requested a review from larsgson April 6, 2023 03:30
@abelpz
Copy link
Member Author

abelpz commented Apr 6, 2023

@samueljd I made some changes to support any attribute to be added in htmlMap, this includes contenteditable.

Check the htmlMap.cjs file to check the test where that is being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsgson larsgson Awaiting requested review from larsgson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abelpz @samueljd