Duplicate Verse Warnings

[jag3773]

In the warning output, Empty Verse sequences are also marked as duplicate verses, as you see here https://door43.org/u/STR/kn_iev/397901cdbe/index.html . It would be much less noise if they were only marked as empty and not duplicate.

[RobH123]

Actually @jag3773 , looking at https://git.door43.org/STR/kn_iev/src/branch/master/42-MRK.usfm, both error messages are correct (they're not just noise), and the duplicate verse message is probably actually the more serious problem. I'm reluctant to remove the warnings when they are indeed correct (even though you're right that both will disappear if the one duplicate empty verse marker is removed). If you really want me to do it, you'll have to INSIST. :-)

[jag3773]

@RobH123 Since the idea is to give people an indication of what specifically is wrong, I'm in favor of showing the root cause, which in this case would be empty verses, right? Clearly, if you have several empty verses then they will be duplicates since '' == '' . But that is merely a symptom of the real issue. So I am in favor of modifying the system such that sequences of empty verses only trigger the empty verse warning and not also the duplicate verse warning.

However, both of the above are inaccurate in this case, because the actual root problem is that the text is using verse bridges and has empty single verse markers in it (because of a tC export problem). The solution here is to remove the empty verse markers and all will be well.

[RobH123]

Ah, I see another issue from reading your comment. The warning text is misleading you. I will clarify the message. tX does NOT compare the CONTENT of verses. The warning message more explicitly should be saying "Duplicated verse NUMBER" (not just "Duplicated verse" as it currently does). That's what I meant when saying this message is more important (in terms of file structure being wrong) than just noting that the verse text is empty.