Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special linting for TSV tN Files #873

Open
jag3773 opened this issue Apr 24, 2019 · 5 comments
Open

Special linting for TSV tN Files #873

jag3773 opened this issue Apr 24, 2019 · 5 comments

Comments

@jag3773
Copy link
Contributor

jag3773 commented Apr 24, 2019

Story

As a tC user I want to see the correctly highlighted text so that I'm not confused when checking my translation.

Notes

The tN TSV files are structured in such a way that they are intended to quote the UGNT text in the OrigQuote field. During the linting process we should verify that all of the OrigQuote entries in the TSV file(s) match what is in the published version of the UGNT.

I think the tC team has some code that may be useful to use here.

cc @benjore @mannycolon @richmahn @RoyalSix @PhotoNomad0 @RobH123

@RobH123
Copy link
Contributor

RobH123 commented Apr 24, 2019

@jag3773 The tX converter part of the system that does the linting has been made to be independent of knowledge about Door43. You pass it a set of files to convert and it passes back the results. Even the manifest file for tN contains no link pointing to the version of UGNT that was used. So it either has to be hard-coded or passed in to the system somehow.

Alternatively, it could be done in the preprocessor in the Door43 code but that's not ideal either.

@RobH123
Copy link
Contributor

RobH123 commented Apr 24, 2019

A nice thing would be to run this linter not only when tN has an update pushed, but also when UGNT has an update pushed. (Don't see an easy way to implement this though.)

@jag3773
Copy link
Contributor Author

jag3773 commented May 1, 2019

Even the manifest file for tN contains no link pointing to the version of UGNT that was used. So it either has to be hard-coded or passed in to the system somehow.

I think that we should make a constraint by convention to require that the Greek and Hebrew referenced in the OrigQuote field must be listed in the relation field of the manifest. Would that work? It would still be a list that would have to be iterated through but it seems like that could solve the problem here?

@RobH123
Copy link
Contributor

RobH123 commented May 1, 2019

Yes, that would be the best way ahead I think. And for other reasons, I think that relation field should include a date or version number even though that requires more manual maintenance. (Also for other reasons, but maybe helpful to my comment just above, maybe the original texts could contain something like a quoted_in field.)

@RobH123
Copy link
Contributor

RobH123 commented Jul 8, 2019

Ok, I done a first pass on this that processes both OT and NT quotes. See https://dev.door43.org/u/unfoldingWord/en_tn/master/ (which has Ruth and Ezra suppressed so more NT errors are shown).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants