remove empty :not selectors (simpler alternative to PR #446) #448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #353
Fixes #370 (partially)
After depseudify, a
:not
pseudo-class may become an empty:not()
. Callingdocument.querySelector
with an empty:not
raises an exception and the entire selector is kept, becausejsdom#findAll
optimistically ignores all errors.This PR adds a second pass to
dePseudify
: after removal ofignoredPseudos
, a new walk is performed in search of empty:not
selectors.Current behavior:
dePseudify
[.control:not(:checked)
] =>.control:not()
document.querySelector('.control:not()')
raises an exception and the selector is kept.Pull proposal:
dePseudify
[.control:not(:checked)
] =>.control
:not()