[WIP] feat: add sourcemap && improve getUmiAlias #11883
Open
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #11883 +/- ##
=======================================
Coverage 28.89% 28.89%
=======================================
Files 488 488
Lines 14892 14892
Branches 3538 3538
=======================================
Hits 4303 4303
Misses 9829 9829
Partials 760 760 ☔ View full report in Codecov by Sentry. |
xc1427
changed the title
fz6m
reviewed
Nov 21, 2023
| @@ -32,7 +32,9 @@ let service: Service; | |||
|
|
|||
| export async function getUmiAlias() { | |||
| if (!service) { | |||
| service = new Service(); | |||
| service = new Service({ | |||
| defaultConfigFiles: [], | |||
There was a problem hiding this comment.
为啥不需要 umirc 里的东西，用户的 alias 这样就收集不到了。
| @@ -3,5 +3,6 @@ import { defineConfig } from 'father'; | |||
| export default defineConfig({ | |||
| cjs: { | |||
| output: 'dist', | |||
| sourcemap: true, | |||
There was a problem hiding this comment.
如果要带着 sourcemap 发到 npm 上的话，体积就变的特别大，目前几乎看不到把 sourcemap 发到 npm 上的。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getUmiAliasactually call "setup" service to collect umi alias. It has a defect when used to test umi-plugin. It will ready the config file in user's project and that could result "invalid config key" error. It can be improved by allowing developer to specify a config path.