[Issue #1] Application crashes (immediately) after choosing 'View log' from the menu. #1337

amaa-99 · 2023-07-25T13:40:28Z

Changed the required version to org.ocpsoft.prettytime:prettytime to 4.0.6.Final (as per the library documentation). This should be compatible with all the target OS versions.

ukanth

Rather than reverting to older version, can you please explain from which class the issue occurs ? we can try fixing with latest version of prettytime.

amaa-99 · 2023-07-28T19:58:38Z

Thanks for having a look.

Please refer to to original issue on my fork:
amaa-99#1

"This is due to the included version of the prettytime library using java 1.8 features which are not available in these OS versions.
As per the library documentation (https://github.com/ocpsoft/prettytime) version 4.0.6.Final or lower is to be used in these cases."

ukanth · 2023-07-29T16:27:25Z

Java 1.8 (Java 8( is not Java 18. It should technically work with latest/old Android versions. I would like to fix the actual issue with 5.x version rather than downgrade it to 4.x

amaa-99 · 2023-07-29T22:12:59Z

I've removed the org.ocpsoft.prettytime:prettytime (which was used in a single spot to format a string), and replaced the implementation to use standard APIs.
(I've removed the related unused code and declarations which made it seem that that was used more often.)

amaa-99 · 2023-07-29T22:13:59Z

app/src/main/java/dev/ukanth/ufirewall/log/LogRecyclerViewAdapter.java

+            Calendar calendar = Calendar.getInstance();
+            calendar.setTimeInMillis(data.getTimestamp());
+            DateFormat dateFormat = DateFormat.getDateTimeInstance(DateFormat.SHORT, DateFormat.SHORT);
+            holder.lastDenied.setText(dateFormat.format(calendar.getTime()));


This is the only place where that is used.

Thanks for PR. Does it retain the same functionality as prettytime ?

That's one of the java standard ways of printing a localized date/time (taking the time zone and ... into consideration).
It should do what's needed for the date/time string shown in the log view.

Actually it was not showing just data and time .It was showing the time lapse like 2s ago, 10s ago, 1 min ago etc.,

Note: In the detail view of the log entries the date/time is shown without any localization.
Probably the localized time should be shown there too.

I think the focus should be kept on fixing the crash first without adding complexity.
The pretty format can always be added on top...
I don't have much passion on which direction the solution goes, but I find it a pity having the app crash for something like that.
In my opinion as long as one can see the date/time of the logged event it's perfect (and it's even localized, so the US won't be mixing months with days ;)). What do you think?

Agree with your point. But I don't see any crashing reports based on this.

app/src/main/java/dev/ukanth/ufirewall/log/LogRecyclerViewAdapter.java

amaa-99 · 2023-07-30T08:21:34Z

app/src/main/java/dev/ukanth/ufirewall/log/LogRecyclerViewAdapter.java

+            if (info != null && info.applicationInfo != null) {
+                Drawable drawable = info.applicationInfo.loadIcon(manager);
+                holder.icon.setBackground(drawable);
+            } else {
                Drawable appIcon = context.getDrawable(R.drawable.ic_unknown);
                holder.icon.setImageBitmap(Api.getBitmapFromDrawable(appIcon));


The

holder.icon.setBackground(drawable);

is not consistent with the similar code a few lines below:

if (Build.VERSION.SDK_INT > android.os.Build.VERSION_CODES.O) { holder.icon.setBackground(context.getDrawable(R.drawable.ic_unknown)); } else { Drawable appIcon = context.getDrawable(R.drawable.ic_unknown); holder.icon.setImageBitmap(Api.getBitmapFromDrawable(appIcon)); }

At first glance it would seem that

holder.icon.setImageBitmap(Api.getBitmapFromDrawable(drawable))

should be used at that spot instead.

ukanth · 2023-08-14T09:43:15Z

I will accept this PR if you handle the exception thrown by prettytime and fall back to normal timestamp rather than completely removing the feature.

amaa-99 · 2023-08-19T16:19:59Z

Could you follow-up on this one? Just cherry pick what's useful into your branch and add the rest...
The issue can be reproduced in the device emulators for the Android 5 and 6: You just need to open the log view with some entries in there.
(Alternatively just add a call to those PrettyTime methods somewhere, e.g. in the creation of the apps list, to see the exception).

amaa-99 · 2023-08-19T16:28:57Z

p.s. This seems to be a duplicate of the [(https://github.com//issues/1344)] issue.

ukanth · 2023-08-20T02:06:09Z

Could you follow-up on this one? Just cherry pick what's useful into your branch and add the rest... The issue can be reproduced in the device emulators for the Android 5 and 6: You just need to open the log view with some entries in there. (Alternatively just add a call to those PrettyTime methods somewhere, e.g. in the creation of the apps list, to see the exception).

Thanks. As indicated above, please add an exception to handle rather than removing prettytime all together. I will merge the PR once that's done.

…log' from the menu. Dropped the use of the org.ocpsoft.prettytime:prettytime library: This fixes the crashes due to the library using unsupported language features on older platforms.

…log' from the menu. Addressed a couple of lint warnings.

…iews. Corrected the date/time format in the details view (e.g. 19:00 would get displayed as '7:00'). Changed the detail view to not show the host name field in case the host name is not known.

…iews. Removed commented out code and unused methods.

amaa-99 changed the title * [Issue #1] Application crashes (immediately) after choosing ' View … [Issue #1] Application crashes (immediately) after choosing ' View … Jul 25, 2023

amaa-99 changed the title ~~[Issue #1] Application crashes (immediately) after choosing ' View …~~ [Issue #1] Application crashes (immediately) after choosing ' View log' from the menu. Jul 25, 2023

amaa-99 changed the title ~~[Issue #1] Application crashes (immediately) after choosing ' View log' from the menu.~~ [Issue #1] Application crashes (immediately) after choosing 'View log' from the menu. Jul 25, 2023

ukanth reviewed Jul 28, 2023

View reviewed changes

amaa-99 force-pushed the 1-application-crashes-immediately-after-choosing-view-log-from-the-menu branch from 85f2e05 to c4732ab Compare July 29, 2023 21:38

amaa-99 commented Jul 29, 2023

View reviewed changes

ukanth reviewed Jul 30, 2023

View reviewed changes

app/src/main/java/dev/ukanth/ufirewall/log/LogRecyclerViewAdapter.java Outdated Show resolved Hide resolved

amaa-99 commented Jul 30, 2023

View reviewed changes

amaa-99 force-pushed the 1-application-crashes-immediately-after-choosing-view-log-from-the-menu branch 2 times, most recently from 6d7f3dc to f65f3ef Compare July 30, 2023 09:16

amaa-99 force-pushed the 1-application-crashes-immediately-after-choosing-view-log-from-the-menu branch from f65f3ef to a2c6320 Compare August 9, 2023 17:45

amaa-99 force-pushed the 1-application-crashes-immediately-after-choosing-view-log-from-the-menu branch from a2c6320 to f71e192 Compare August 19, 2023 16:14

amaa-99 mentioned this pull request Aug 19, 2023

Crash with java.lang.NoSuchMethodError when opening protocol #1344

Open

amaa-99 mentioned this pull request Aug 22, 2023

[ISSUE] Afwall+ v3.5.3 crash when tapping view log #1300

Open

amaa-99 force-pushed the 1-application-crashes-immediately-after-choosing-view-log-from-the-menu branch from f71e192 to e2871dd Compare September 22, 2023 10:43

* [Issue #1] Application crashes (immediately) after choosing ' View …

a6769cf

…log' from the menu. Dropped the use of the org.ocpsoft.prettytime:prettytime library: This fixes the crashes due to the library using unsupported language features on older platforms.

amaa-99 force-pushed the 1-application-crashes-immediately-after-choosing-view-log-from-the-menu branch from e2871dd to 4c3a7b3 Compare September 22, 2023 11:19

amaa-99 mentioned this pull request Sep 22, 2023

Proper multi-user support #1349

Open

amaa-99 added 3 commits September 22, 2023 17:51

* [Issue #1] Application crashes (immediately) after choosing ' View …

72f448c

…log' from the menu. Addressed a couple of lint warnings.

* [Issue #18] The date/time formatting is not consistent across all v…

821415d

…iews. Corrected the date/time format in the details view (e.g. 19:00 would get displayed as '7:00'). Changed the detail view to not show the host name field in case the host name is not known.

* [Issue #18] The date/time formatting is not consistent across all v…

a5f1f16

…iews. Removed commented out code and unused methods.

amaa-99 force-pushed the 1-application-crashes-immediately-after-choosing-view-log-from-the-menu branch from 4c3a7b3 to a5f1f16 Compare September 22, 2023 15:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Issue #1] Application crashes (immediately) after choosing 'View log' from the menu. #1337

[Issue #1] Application crashes (immediately) after choosing 'View log' from the menu. #1337

amaa-99 commented Jul 25, 2023 •

edited

ukanth left a comment

amaa-99 commented Jul 28, 2023 •

edited

ukanth commented Jul 29, 2023

amaa-99 commented Jul 29, 2023 •

edited

amaa-99 Jul 29, 2023

ukanth Jul 30, 2023

amaa-99 Jul 30, 2023

ukanth Jul 31, 2023

amaa-99 Aug 9, 2023

amaa-99 Aug 9, 2023

ukanth Aug 14, 2023

amaa-99 Jul 30, 2023 •

edited

ukanth commented Aug 14, 2023

amaa-99 commented Aug 19, 2023

amaa-99 commented Aug 19, 2023

ukanth commented Aug 20, 2023

[Issue #1] Application crashes (immediately) after choosing 'View log' from the menu. #1337

Are you sure you want to change the base?

[Issue #1] Application crashes (immediately) after choosing 'View log' from the menu. #1337

Conversation

amaa-99 commented Jul 25, 2023 • edited

ukanth left a comment

Choose a reason for hiding this comment

amaa-99 commented Jul 28, 2023 • edited

ukanth commented Jul 29, 2023

amaa-99 commented Jul 29, 2023 • edited

amaa-99 Jul 29, 2023

Choose a reason for hiding this comment

ukanth Jul 30, 2023

Choose a reason for hiding this comment

amaa-99 Jul 30, 2023

Choose a reason for hiding this comment

ukanth Jul 31, 2023

Choose a reason for hiding this comment

amaa-99 Aug 9, 2023

Choose a reason for hiding this comment

amaa-99 Aug 9, 2023

Choose a reason for hiding this comment

ukanth Aug 14, 2023

Choose a reason for hiding this comment

amaa-99 Jul 30, 2023 • edited

Choose a reason for hiding this comment

ukanth commented Aug 14, 2023

amaa-99 commented Aug 19, 2023

amaa-99 commented Aug 19, 2023

ukanth commented Aug 20, 2023

amaa-99 commented Jul 25, 2023 •

edited

amaa-99 commented Jul 28, 2023 •

edited

amaa-99 commented Jul 29, 2023 •

edited

amaa-99 Jul 30, 2023 •

edited