-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #3150 (winding pack current density constraint) #3160
base: main
Are you sure you want to change the base?
Fixed #3150 (winding pack current density constraint) #3160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's some indentation that needs correcting. Also, why has an image been put in the examples directory? Perhaps this belongs in the docs?
process/current_drive.py
Outdated
@@ -1279,8 +1278,7 @@ def iternb(self): | |||
fshine : output real : shine-through fraction of beam | |||
This routine calculates the current drive parameters for a | |||
neutral beam system, based on the 1990 ITER model. | |||
AEA FUS 251: A User's Guide to the PROCESS Systems Code | |||
ITER Physics Design Guidelines: 1989 [IPDG89], N. A. Uckan et al, | |||
ITER Physics Design Guidelines: 1989 [IPDG89], N. A. Uckan et al, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix indentation please.
process/evaluators.py
Outdated
@@ -37,8 +37,7 @@ def fcnvmc1(self, n, m, xv, ifail): | |||
n-dimensional point of interest xv. | |||
Note that the equality constraints must precede the inequality | |||
constraints in conf. | |||
AEA FUS 251: A User's Guide to the PROCESS Systems Code | |||
:param n: number of variables | |||
:param n: number of variables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, fix indentation please.
The image files plot_proc_1, 2 and 3 must have been put into the examples folder automatically when I ran However, they seem to fit, and since only the new third page is shown in the changes tab, I suppose that the other two pages, plot_proc_1.png and plot_proc_2.png were already there, so I have left plot_proc_3.png there. |
I have corrected indentations in several files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fixup the changes to comments to eliminate the 2 correcting commits and eliminate churn. The plot_procX.png
figures should be created by running the examples.ipynb
notebook, and the resulting pngs displayed in the notebook. Please look at how figure 1 and 2 are being handled by the notebook to match. Thanks!
The plot_proc figures have nothing to do with this pull request. They result from Chris's edit. If the example notebook needs changing it should be done there. I will delete the unwanted png. |
bb88e51
to
10814bc
Compare
Unwanted png removed. Rebased. |
…te reference to Users' Guide.
I have fixed the conflict localy, but when I rebased and then tried to force push, I couldn't do it:
|
10814bc
to
b1db908
Compare
Fixed #3150.
Removed obsolete references to PROCESS Users's Guide.