Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect error in winding pack current density constraint. #3150

Open
ajpearcey opened this issue Apr 23, 2024 · 1 comment · May be fixed by #3160
Open

Incorrect error in winding pack current density constraint. #3150

ajpearcey opened this issue Apr 23, 2024 · 1 comment · May be fixed by #3160

Comments

@ajpearcey
Copy link
Collaborator

In constraint 35 for the current density in the winding pack the constraint error is calculated as

tmp_err = jwptf - jwptf

This is wrong and surely causes the constraint to never be violated? I believe it should be

tmp_err =  jwptf - jwdgpro 
@mkovari
Copy link
Collaborator

mkovari commented Apr 23, 2024

In this output, for example, the reported error is zero, but the normalised residue is not, because it is printing a different variable which is correct:

                                               physical                 constraint                 normalised
                                              constraint                 residue                    residue
   17  J_winding pack/J_protection limit     <  2.5694E+07 A/m2         0.0000E+00 A/m2           -2.9894E-07

Note that I think tmp_err is only used in the output table, not in the rest of the code, so this error doesn't affect the results.

mkovari pushed a commit that referenced this issue Apr 25, 2024
@mkovari mkovari linked a pull request Apr 25, 2024 that will close this issue
mkovari pushed a commit that referenced this issue May 9, 2024
mkovari pushed a commit that referenced this issue May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants