[WIP] implement some API methods #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbuchbinder
pushed a commit
to jbuchbinder/uget
that referenced
this pull request
May 20, 2018
File: Put errors in core.File interface to facilitate better handling. Priorities: don't use math.Nextafter. The use of math.Nextafter turned out to be very flawed for grandchildren requests. Particularly, if request #0 bundles 10 requests uget#1-10, uget#3 of which bundles another 2 requests uget#11-12, this request uget#12 will have the same priority as request uget#4, which of course is not desired. Instead, an equidistant gap should be found between the two sibling requests, however, this requires a lot of work and tracking. The priorities work on a more sophisticated level now, recursing up the ancestry to determine the preceding node. CLI: Use File#Err() to determine a file error. Additionally, make it clear in the summary if there was a file that has unknown length. Add documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.