Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center login page and show success and error message on login / forgot password #65

Merged
merged 5 commits into from
Feb 29, 2020

Conversation

ghost
Copy link

@ghost ghost commented Feb 24, 2020

@iguit0 , I have also changed the logo from the application and fixed the bug when installing the dependencies (see package.json, the update for React Scrips), resolve #46 #49

@ghost ghost added bug Something isn't working enhancement New feature or request labels Feb 24, 2020
@ghost ghost requested a review from iguit0 February 24, 2020 03:49
@ghost ghost self-assigned this Feb 24, 2020
@ghost
Copy link
Author

ghost commented Feb 24, 2020

Reference bug React Scripts

@ghost
Copy link
Author

ghost commented Feb 24, 2020

Reference context level Noti Snack

@@ -133,6 +152,11 @@ const FormikSign = ({ classes, setAuthentication, setUser, props }) => (
resetForm();
} catch (error) {
console.log(error);

enqueueSnackbar("Error on login, contact an admin", {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sphinxs This message should me more clear to the user.
"contact an admin" sounds like an internal error, which is not true.
It's just the password (or e-mail) that are incorrect.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I have removed the contact admin into another PR

Copy link
Contributor

@iguit0 iguit0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Images are broken and not showing properly.
    logo_img_broken

  2. Successful message (on login) are not showing up.

@sphinxs

@ghost
Copy link
Author

ghost commented Feb 29, 2020

  1. Images are broken and not showing properly.
    logo_img_broken
  2. Successful message (on login) are not showing up.

@sphinxs

The image will be fixed at the #48 , once I need to download a image editor and the message is not shown because the user is redirected

@iguit0 iguit0 merged commit 2cf4154 into version Feb 29, 2020
@iguit0 iguit0 deleted the login-fixes branch February 29, 2020 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align the login form / forgot password at the center of the screen
1 participant