Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make routeSnapshot data available in breadcrumb function #133

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

udayvunnam
Copy link
Owner

What is this PR about

  • make routeSnapshot data available in breadcrumb function
  • use NavigationEnd instead of GuardCheck

PR Checklist

Please check if your PR fulfils the following requirements:

  • The commit message follows the guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

@github-actions
Copy link

Hello 👋 @udayvunnam
Thank you for raising your pull request. Please make sure you have followed our contributing guidelines. We will review it as soon as possible.

@stale
Copy link

stale bot commented Jul 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 30, 2022
@luizagabriela
Copy link

Hello!

There are still plans to merge the this PR to make activatedRouteSnapshot data available in breadcrumb function?

@udayvunnam udayvunnam removed the wontfix This will not be worked on label Oct 3, 2022
@udayvunnam
Copy link
Owner Author

Yes, @luizagabriela

@luizagabriela
Copy link

I'm glad to hear that this functionality will be integrated, it will help us.
Do you know when the changes will be merge?

@RalucaCorb
Copy link

Hello
Do you know when this PR will be merged?

@udayvunnam
Copy link
Owner Author

I will try to get this fixed and merged over the weekend

@RalucaCorb
Copy link

Great! Thanks.

@luizagabriela
Copy link

Hi! Do you know when this PR will be merged?

@stale
Copy link

stale bot commented May 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 8, 2023
@miroslavgrozdanovski
Copy link

Hi @udayvunnam, any plans to merge this soon? Thanks!

@stale stale bot removed the wontfix This will not be worked on label Aug 7, 2023
Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 15, 2023
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot closed this Apr 5, 2024
@udayvunnam udayvunnam reopened this Apr 5, 2024
@stale stale bot removed the wontfix This will not be worked on label Apr 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants