Implementing test cases to GET and DELETE user models at the api/users endpoint #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuyakonwu
changed the title
giomhern
requested changes
Nov 30, 2023
| list_response = self.client.get(list_url) | ||
| assert list_response.status_code == 200 | ||
|
|
||
| detail_response = self.client.get(detail_url) |
There was a problem hiding this comment.
Perhaps compare fields here to ensure that the response and the user (from the factory) match!
There was a problem hiding this comment.
There would be no simple way to do that as the faker is random, I will fix that once I implement the patch test!
giomhern
approved these changes
Nov 30, 2023
| @@ -299,6 +299,7 @@ def test_user_get(self): | |||
|
|
|||
| def test_user_delete(self): | |||
| user = UserFactory() | |||
| self.assertEqual(User.objects.count(), 1) | |||
|
I will hold off on merging this until the JWT user |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the need for testing of the User API endpoints, specifically focusing on the GET and DELETE functionalities. The introduced tests ensure the reliability and correctness of these critical features, contributing to the overall stability and maintainability of Chigame.