Replace File References #949
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taheralfayad
added
bug
enhancement
javascript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, whenever a user attempts to replace a file using the file replacement modal, it only allows them to upload the new file to the files section and delete the previous version. However, the application does not account for references where the previous file may be used (assignments, pages, modules, etc...), and so the user ends up with a few broken links on their hands. This PR seeks to address this issue. The code in this pull request will replace all instances of the previous file in assignments, modules, wiki pages, syllabus, quizzes, and individual quiz questions, with the the new file. It also removes the deleting functionality to maintain links that the CanvasAPI does not permit us to change (announcements for example).