-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing issue unresolve bug and adding concept of scanIssue/decreased … #873
base: main
Are you sure you want to change the base?
Conversation
…amount of intial data on issue load
@taheralfayad I'll take a look, thanks for pointing that out. |
let showExample = false | ||
if (!this.props.t(`rule.example.${activeIssue.scanRuleId}`).includes('rule.example')) { | ||
showExample = true | ||
} | ||
|
||
let code = this.prepareCode(activeIssue) | ||
if (!this.state.issueDetailsPending) { | ||
UfixitForm = ufixitService.returnIssueForm(activeIssue) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot find ufixitService
anywhere in the React files, only on this line. Returns an error:
Uncaught (in promise) ReferenceError: ufixitService is not defined
at a.value (app.js:252:268294)
at Pa (app.js:377:69887)
at Na (app.js:377:69682)
at gs (app.js:377:105481)
at cl (app.js:377:96728)
at sl (app.js:377:96653)
at Zs (app.js:377:93683)
at app.js:377:45325
at t.unstable_runWithPriority (app.js:11:3844)
at Fi (app.js:377:45034)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm that like @taheralfayad, I also get the infinite loop upon clicking on any issue, as well as a 404 error in the logs.
Hey @atarisafari, it's been a while since this PR has had any updates but have you by any chance been able to test the issue @taheralfayad and I were having, regarding the immediate infinite loading screen? I'm unable to test the branch as is. Thank you! |
…amount of intial data on issue load
Fixes: #867
Adds concept of loading less issue data on initial app load, but scanning for further issue data when the issue is opened in the modal.