Try implementing Django's JavaScript translation catalog again #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneycb
added
backend
Merged
eAlasdair
approved these changes
Sep 25, 2020
Not putting this into the current release |
|
Since this also adds the gettexts, this PR should implement them into everything added in the current release once it's out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1415 an attempt was made at using Django's JavaScript translation catalog. However an error occurred (detailed in #1409) and the changes had to be rolled back due to a survey running on the develop site at the time.
This PR implements the same changes that were in #1415 but also has the changes to create the
djangojsmessage file.Hopefully resolves #1409