New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0.0-rc.1 #1
Draft
expede
wants to merge
33
commits into
main
Choose a base branch
from
v1-rc1
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
v1.0.0-rc.1 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgins
reviewed
Oct 19, 2023
|
||
### 1.1.1 ActID | ||
|
||
An Action Identifier (ActID) is the content address of an [Action]. It can be found direction in an Invocation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
An Action Identifier (ActID) is the content address of an [Action]. It can be found direction in an Invocation: | |
An Action Identifier (ActID) is the content address of an [Action]. It can be found directly in an Invocation: |
const actId = invocation.inv.run.act.asCid() | ||
``` | ||
|
||
A Receipt MAY have multiple input addresses. For instance, if an Action contains a promise versus when it's fully reified, the associated Receipt is the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
A Receipt MAY have multiple input addresses. For instance, if an Action contains a promise versus when it's fully reified, the associated Receipt is the same. | |
A Receipt MAY have multiple input addresses. For instance, whether an Action contains a promise or is fully reified, the associated Receipt will be the same. |
Possible rephrasing.
|
||
# 3. Resolution | ||
|
||
Using a shared cache[^bbd], many cooperating processes can collaborate on multiple separate goals while reusing each others results. The exact mechanism is left to the implementation, but [pubsub], [gossip], and [DHT]s are all viable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Using a shared cache[^bbd], many cooperating processes can collaborate on multiple separate goals while reusing each others results. The exact mechanism is left to the implementation, but [pubsub], [gossip], and [DHT]s are all viable. | |
Using a shared cache[^bbd], many cooperating processes can collaborate on multiple separate goals while reusing each other's results. The exact mechanism is left to the implementation, but [pubsub], [gossip], and [DHT]s are all viable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview 馃摎
Splitting out promises and pipelining from Invocation, since it's not required for a bunch of use cases. It also makes each spec more focused.