Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup for Sep 2023 #65

Merged
merged 13 commits into from Aug 29, 2023
Merged

Cleanup for Sep 2023 #65

merged 13 commits into from Aug 29, 2023

Conversation

augustopher
Copy link
Contributor

  • Update Makefile to match CinFin repo
  • Update environment to Python 3.11, pandas 2.0
  • Add my bio slide
  • Update schedule

@augustopher augustopher marked this pull request as draft August 9, 2023 20:28
@augustopher
Copy link
Contributor Author

augustopher commented Aug 9, 2023 •
edited

Cleanups needed from CinFin class:

  • Update h4 headers to h3
  • Convert "Your Turn" from custom CSS to slide header
  • Double-check slide splits (fragment vs. sub-slide) and code block widths

@augustopher augustopher marked this pull request as ready for review August 10, 2023 00:42
cunningjames
cunningjames approved these changes Aug 29, 2023
View reviewed changes
Copy link

@cunningjames cunningjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Everything compiles properly and I can't find any glaring errors.

@augustopher augustopher merged commit 7e9c0af into develop Aug 29, 2023
1 check passed
@augustopher augustopher deleted the cleanup-2023 branch August 29, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cunningjames cunningjames cunningjames approved these changes

@eswan18 eswan18 Awaiting requested review from eswan18

@bradleyboehmke bradleyboehmke Awaiting requested review from bradleyboehmke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@augustopher @cunningjames