Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/move to delegated compute #920

Conversation

0x4007
Copy link
Member

@0x4007 0x4007 commented Feb 26, 2024

Exploring what was not included

0x4007 and others added 29 commits December 8, 2023 17:36
@0x4007
Copy link
Member Author

0x4007 commented Feb 26, 2024

Looks like there were some small changes around database operations for NFTs by whilefoo and switching the logger to gitcoindev's npm module

- name: Enable Corepack and Install Correct Yarn Version
run: |
corepack enable
yarn set version 4.0.2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the core pack stuff and use yarn 1.2 or whatever is the default.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. If I remember correctly it was a workaround from @wannacfuture and it had to be added to avoid an error but I do not remember the root cause for introducing this change.

@0x4007 0x4007 marked this pull request as ready for review February 26, 2024 17:10
@0x4007
Copy link
Member Author

0x4007 commented Feb 26, 2024

@whilefoo @gitcoindev just wanted to know if your changes all look intact. This is being merged sort of out of order and wanted to make sure we are not causing problems with this merge.

@gitcoindev
Copy link
Contributor

@whilefoo @gitcoindev just wanted to know if your changes all look intact. This is being merged sort of out of order and wanted to make sure we are not causing problems with this merge.

I am on it, will review asap.

Copy link
Contributor

@gitcoindev gitcoindev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from my side. The logger changes integration looks fine. I hope nothing was skipped.

- name: Enable Corepack and Install Correct Yarn Version
run: |
corepack enable
yarn set version 4.0.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. If I remember correctly it was a workaround from @wannacfuture and it had to be added to avoid an error but I do not remember the root cause for introducing this change.

@0x4007 0x4007 merged commit e45abb5 into ubiquity:refactor/move-to-delegated-compute Feb 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants