Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: making ignoring of children dynamic #825

Open
wants to merge 11 commits into
base: development
Choose a base branch
from
Open

build: making ignoring of children dynamic #825

wants to merge 11 commits into from

Conversation

GaryThisSidee
Copy link

Resolves #772

@netlify
Copy link

netlify bot commented Sep 24, 2023 •
edited

✅ Deploy Preview for ubiquibot-staging ready!

Name Link
🔨 Latest commit d907861
🔍 Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/651f0a5258ad2b00082f559c
😎 Deploy Preview https://deploy-preview-825--ubiquibot-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@GaryThisSidee
Copy link
Author

@whilefoo

whilefoo
whilefoo requested changes Sep 25, 2023
View reviewed changes
src/helpers/comment.ts Outdated Show resolved Hide resolved
src/configs/ubiquibot-config-default.ts Outdated Show resolved Hide resolved
wannacfuture
wannacfuture reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@wannacfuture wannacfuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove itemsToExclude prop from parseComments function and just get that information from the config in that function.

whilefoo
whilefoo requested changes Sep 26, 2023
View reviewed changes
src/helpers/comment.ts Outdated Show resolved Hide resolved
GaryThisSidee and others added 2 commits September 27, 2023 01:29
@GaryThisSidee @whilefoo
fix: removed the uncessary line
71491f8 
Co-authored-by: whilefoo <139262667+whilefoo@users.noreply.github.com>
fix: made the comments parser functions to take the ignore children f…
6edb475 
…rom the config directly
whilefoo
whilefoo requested changes Oct 2, 2023
View reviewed changes
src/helpers/comment.ts Outdated Show resolved Hide resolved
whilefoo
whilefoo requested changes Oct 5, 2023
View reviewed changes
src/types/config.ts Outdated Show resolved Hide resolved
GaryThisSidee and others added 2 commits October 6, 2023 00:28
@GaryThisSidee @whilefoo
fix: make the ignore_children property optional
c295810 
Co-authored-by: whilefoo <139262667+whilefoo@users.noreply.github.com>
fix: placed a Optional chaining operator
d907861
@GaryThisSidee
Copy link
Author

@wannacfuture can u take a look

@GaryThisSidee
Copy link
Author

@0xcodercrane can u take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wannacfuture wannacfuture wannacfuture approved these changes

@whilefoo whilefoo whilefoo approved these changes

@0xcodercrane 0xcodercrane Awaiting requested review from 0xcodercrane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ignore-children comment incentive config
3 participants
@GaryThisSidee @wannacfuture @whilefoo