September 2023 Update Adjustments #818
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ubiquibot-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
0x4007
previously approved these changes
Sep 23, 2023
|
I made some additional adjustments |
|
My question still stands |
…hey were also the assignee
|
It should be all now |
0x4007
reviewed
Sep 25, 2023
0x4007
requested changes
Sep 25, 2023
| const claimUrlRegex = new RegExp(`\\((${permitBaseUrl}\\?claim=\\S+)\\)`); | ||
| const permitCommentIdx = comments.findIndex((e) => e.user.type === UserType.Bot && e.body.match(claimUrlRegex)); | ||
| const claimUrlRegex = new RegExp(`\\((${permitBaseUrl}\\S+)\\)`); | ||
| const permitCommentIdx = comments.findIndex((e) => e.user.type === UserType.Bot && e.body.match(claimUrlRegex) && e.body.includes("Task Assignee Reward")); |
There was a problem hiding this comment.
Maybe it makes sense to call this Assignee Reward because task is implicit
There was a problem hiding this comment.
We shouldn't change it because it will break backwards compatibility. We need to implement comment metadata first and then we can change format
| @@ -148,8 +154,8 @@ export const calculateIssueCreatorReward = async (incentivesCalculation: Incenti | |||
| incentivesCalculation.paymentPermitMaxPrice | |||
| ); | |||
|
|
|||
| if (!result || !result.account || !result.amountInETH) { | |||
| throw new Error("Failed to generate permit for issue creator because of missing account or amountInETH"); | |||
| if (!result || !result.account || !result.rewardInTokens) { | |||
There was a problem hiding this comment.
I don't think that's as expressive as inBigNumber etc it implies 1e18 format
There was a problem hiding this comment.
it's not in 1e18 format, but with decimals like 5.235
Co-authored-by: アレクサンダー.eth <4975670+pavlovcik@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #798