Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config/context overridden by another webhook #801

Draft
wants to merge 13 commits into
base: development
Choose a base branch
from
Draft

Config/context overridden by another webhook #801

wants to merge 13 commits into from

Conversation

Sadaf-A
Copy link
Contributor

@Sadaf-A Sadaf-A commented Sep 23, 2023

Resolves #732

@netlify
Copy link

netlify bot commented Sep 23, 2023 •
edited

✅ Deploy Preview for ubiquibot-staging ready!

Name Link
🔨 Latest commit bee6ac6
🔍 Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/65377bcfb6774e0008b38071
😎 Deploy Preview https://deploy-preview-801--ubiquibot-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

0x4007
0x4007 requested changes Sep 23, 2023
View reviewed changes
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to pass CI before you request a review.

@0x4007 0x4007 marked this pull request as draft September 23, 2023 14:46
@0x4007
Copy link
Member

0x4007 commented Sep 23, 2023

I guess this is for you @whilefoo

whilefoo
whilefoo requested changes Sep 23, 2023
View reviewed changes
Copy link
Collaborator

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your code is failing because you removed botConfig variable but everywhere in the code it's still used

src/bindings/event.ts Outdated Show resolved Hide resolved
whilefoo
whilefoo requested changes Oct 6, 2023
View reviewed changes
src/bindings/event.ts Show resolved Hide resolved
src/bindings/event.ts Outdated Show resolved Hide resolved
@Sadaf-A Sadaf-A marked this pull request as ready for review October 24, 2023 08:11
@Sadaf-A Sadaf-A marked this pull request as draft October 24, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4007 0x4007 0x4007 requested changes

@whilefoo whilefoo whilefoo requested changes

@0xcodercrane 0xcodercrane Awaiting requested review from 0xcodercrane

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config/context overridden by another webhook
4 participants
@Sadaf-A @0x4007 @0xcodercrane @whilefoo