generated from ubiquity/ts-template
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Statistics rewards #1129
Merged
Merged
Feat: Statistics rewards #1129
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
06213b7
feat: setting up statistics
devpanther 8c03c85
feat: ignore rewards json
devpanther a3b9f21
feat: log for test
devpanther 3ca77c7
fix: completed rewards getter
devpanther 3f6a26e
fix: rewards empty
devpanther 4f6311b
fix: rewards empty
devpanther c0b14ea
fix: rewards empty test
devpanther 4cfcb46
fix: rewards empty test: debug
devpanther d911e35
fix: ignoring empty pricing
devpanther 9bbe43f
fix: assigned is a label
devpanther 2fe5706
fix: assigned is a label
devpanther 03e8bfe
fix: ready to go
devpanther d1fffd2
fix: change ignore path
devpanther d1d2a7a
Update helpers/github.ts
0x4007 4e01bff
fix: quick test run
devpanther 75a67a8
fix: add NaN error handler
devpanther 8a07b59
fix: remove test console log
devpanther File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,4 +11,5 @@ node_modules | |
coverage | ||
coverage.txt | ||
total-rewards.txt | ||
total-rewards.json | ||
junit.xml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
export type Statistics = { | ||
rewards: { | ||
notAssigned: number; | ||
assigned: number; | ||
completed: number; | ||
total: number; | ||
}; | ||
tasks: { | ||
notAssigned: number; | ||
assigned: number; | ||
completed: number; | ||
total: number; | ||
}; | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this have proper error handling for NaN etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added an error handling now, although i had a check for price not set earlier but NaN check would make it better