Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variable name error in README example #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix variable name error in README example #96

wants to merge 1 commit into from

Conversation

mnoack
Copy link

@mnoack mnoack commented Apr 18, 2019

No description provided.

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2019 •
edited

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.277% when pulling 817cb66 on mnoack:fix-readme-reporter-r-syntax-error into 1ed35a1 on uber-go:master.

martin-mao
martin-mao approved these changes May 22, 2019
View reviewed changes
Copy link

@martin-mao martin-mao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-mao martin-mao martin-mao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mnoack @CLAassistant @coveralls @martin-mao