Support general nonnil->nonnil function contract, i.e., having a single nonnil but any numbers of any, e.g. contract(_,nonnil->nonnil,_) #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## zzq/function-contracts/auto-infer #41 +/- ##
=====================================================================
- Coverage 87.56% 87.55% -0.02%
=====================================================================
Files 54 54
Lines 8452 8547 +95
=====================================================================
+ Hits 7401 7483 +82
- Misses 896 906 +10
- Partials 155 158 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zzqatuber
force-pushed
the
zzq/function-contracts/general-nonnil
branch
from
7002595
to
ddbcbfa
Compare
zzqatuber
force-pushed
the
zzq/function-contracts/general-nonnil
branch
from
ddbcbfa
to
881b950
Compare
yuxincs
added a commit
that referenced
this pull request
Nov 29, 2023
@zzqatuber has implemented contract support in NilAway and has merged the manual contract support (i.e., via manual annotations such as `//contract(nonnil->nonnil)`) in main NilAway but hidden under a flag. After internal performance validations there are no major performance/functionality degradations of simply enabling this feature, therefore this PR removes the hidden flag and make it available in NilAway. After this PR, we will prioritize merging the automatic inference of the function contracts (i.e., PR #40 , PR #41 , and PR #42 ).
yuxincs
force-pushed
the
zzq/function-contracts/auto-infer
branch
from
ade60da
to
9a435c7
Compare
yuxincs
force-pushed
the
zzq/function-contracts/auto-infer
branch
3 times, most recently
from
53d4d87
to
1243676
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support general nonnil->nonnil function contract, i.e., having a single nonnil but any numbers of any, e.g. contract(,nonnil->nonnil,).