Fix convergence problem due to unbounded growing of assertion tree #244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the convergence issues causes by unbounded growing of assertion trees with assignments in a loop, such as in the simple example shown below.
Here, the assertion tree should look like
root -> varAssertionNode (a) -> fldAssertionNode (f)
. However, the assertion before was growing unboundedly (root -> a -> f -> f -> f -> ...
) until thestableRoundLimit
was hit. This simple function was taking 7 iterations to converge, while after the code change it now takes only 3 iterations to converge.Taking this opportunity, I have also added tests for testing fixpoint convergence. For this, I refactored existing infrastructure for anonymous functions and generalized it.
Note: the goal of this PR is to improve performance only, and should not have any effect on the reported errors.