Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Wait until window is inited before coping ToxID from Toxcore #1307

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[Windows] Wait until window is inited before coping ToxID from Toxcore #1307

wants to merge 1 commit into from

Conversation

redmanmale
Copy link
Contributor

@redmanmale redmanmale commented Oct 27, 2018 •
edited by GrayHatter

Fixes #592.

This change is Reviewable

@GrayHatter
Copy link
Member

What's the goal of this?

I hate the idea of blocking on toxcore thread waiting for the main thread...

@redmanmale
Copy link
Contributor Author

The goal is to avoid this thing from happening.
In that case user is unable to see or copy his ToxID.
error

@GrayHatter
Copy link
Member

how about preloading that text entry field with "Loading ToxID..." instead?

@redmanmale
Copy link
Contributor Author

I'll try. Just didn't think about it.

@GrayHatter
Copy link
Member

@redmanmale bump

@redmanmale
Copy link
Contributor Author

Got it, I'm planning to finish this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tox ID isn't displayed
2 participants
@redmanmale @GrayHatter