Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing libraries to make_test that need to be linked to the #1181

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jhert0
Copy link
Member

@jhert0 jhert0 commented Feb 14, 2018

test


This change is Reviewable

Copy link
Member

@GrayHatter GrayHatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't seem like the right way +@robinlinden knows cmake better than I do

Reviewable status: 1 file needs 2 more reviewers, 1 assignee LGTMs are missing, missing Admin LGTM at current revision.

@robinlinden
Copy link
Member

The proper thing would be to, instead of doing things like #include "../src/updater.c to test the updater, you do something like target_link_library(test_updater library_containing_updater), and you'd get all dependencies and header files automagically.

Basically, we'd have to rewrite our main CMakeLists to create a utox_core library or something similar.

@GrayHatter
Copy link
Member

@robinlinden meson when?

Copy link
Member

@robinlinden robinlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better than it was before.

@robinlinden robinlinden assigned ghost and unassigned robinlinden Oct 23, 2020
@ghost
Copy link

ghost commented Nov 12, 2020

@endoffile78 please rebase and please give some sort of summary in commit message of why your shit is great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants