Group chats logging

[redmanmale]

Fixes #231.

Since we haven't persistent chats yet, chat log could not be loaded.
So the only case when we need that log is export as plain text which was implemented in that PR.

Also I added unique pseudo-identifier for each new chat. If you are not okay with that I'm looking forward to your options for this.

Merge after #1074 (there will be group settings layout update).

---

This change is 

[robinlinden]

Reviewed 16 of 16 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

src/chatlog.c, line 242 at r1 (raw file):

}

void utox_export_chatlog_init(uint32_t chat_number, bool is_chat) {

I'd prefer is_group or is_groupchat instead of is_chat.

---

src/groups.c, line 96 at r1 (raw file):

    uint8_t random[TOX_PUBLIC_KEY_SIZE];
    for (uint8_t i = 0; i < TOX_PUBLIC_KEY_SIZE; ++i)
    {

This goes on the line above. (1tbs)

---

Comments from Reviewable

[redmanmale]

Review status: 5 of 19 files reviewed at latest revision, 2 unresolved discussions.

---

src/chatlog.c, line 242 at r1 (raw file):

Previously, robinlinden (Robin Lindén) wrote…

I'd prefer is_group or is_groupchat instead of is_chat.

Done.

---

src/groups.c, line 96 at r1 (raw file):

Previously, robinlinden (Robin Lindén) wrote…

This goes on the line above. (1tbs)

Done.

---

Comments from Reviewable

[redmanmale]

Review status: 3 of 19 files reviewed at latest revision, 3 unresolved discussions.

---

src/xlib/gtk.c, line 330 at r2 (raw file):

            LOG_ERR("GTK", "Could not get group with number: %u", chat->chat_number);
            free(chat);
            utoxGTK_open = false;

Add fix like in #1113.

---

Comments from Reviewable

[redmanmale]

4ac6ce4 is bad. And it needs to be reverted and fixed.

When I merge these to functions (for Win7 and WinXP) in one they were completely the same.
But they should not be.
In WinXP UTOX_FILE_NAME_LENGTH (1024) should not exits because MAX_MATH is 260.

[GrayHatter]

Reviewed 1 of 16 files at r1, 2 of 16 files at r2.
Review status: 5 of 18 files reviewed at latest revision, 4 unresolved discussions.

---

src/ui.c, line 313 at r4 (raw file):

    /* Group Settings */
    CREATE_EDIT(group_topic, 10, 95, -10, 24);
    CREATE_BUTTON(export_chatlog_group, 10, 125, _BM_SBUTTON_WIDTH, _BM_SBUTTON_HEIGHT); //TODO: Move to layout and fix position

I'm gonna block on this one. Solve the TODO before we merge this.

---

Comments from Reviewable

[redmanmale]

Review status: 3 of 18 files reviewed at latest revision, 4 unresolved discussions.

---

src/ui.c, line 313 at r4 (raw file):

Previously, GrayHatter (Gregory Mullen) wrote…

I'm gonna block on this one. Solve the TODO before we merge this.

Done.

---

Comments from Reviewable

[GrayHatter]

somewhat related @utox/devs anyone know if >1 thread can call chatlog functions at the same time? I.e., do we need to add thread locking (per the conversation in IRC a few days back)

Reviewed 2 of 16 files at r2, 1 of 10 files at r3, 1 of 1 files at r4, 1 of 3 files at r5, 2 of 6 files at r6.
Reviewable status: 17 files need 2 more reviewers, 5 open discussions remaining, missing Admin LGTM at current revision.

---

src/chatlog.h, line 60 at r6 (raw file):

 * Setup for exporting the chat log to plain text
 */
void utox_export_chatlog_init(uint32_t chat_number, bool is_groupchat);

groups vs users should be two different functions. likely with chatlog_export_core_init() for the actual processing

---

src/chatlog.c, line 242 at r1 (raw file):

Previously, redmanmale (redmanmale) wrote…

Done.

sorry, I'm gonna make it more complicated

---

src/android/main.c, line 284 at r6 (raw file):

void native_export_chatlog_init(uint32_t chat_number, bool is_groupchat)
{   /* Unsupported on Android */ }

FYI, rip android... no love :/

---

src/layout/group.c, line 91 at r6 (raw file):

    setfont(FONT_SELF_NAME);

    drawstr(x + SCALE(10), y + SCALE(MAIN_TOP + 10), GROUP_TOPIC);

It's been so long, is this the new way of drawing? IIRC this is the legacy way.