remove some ts-ignore

uNmAnNeR · Jun 21, 2023 · c16f160 · c16f160
1 parent 3f15c4c
commit c16f160
Show file tree

Hide file tree

Showing 8 changed files with 18 additions and 23 deletions.
diff --git a/packages/imask/src/controls/html-contenteditable-mask-element.ts b/packages/imask/src/controls/html-contenteditable-mask-element.ts
@@ -6,7 +6,6 @@ export default
 class HTMLContenteditableMaskElement extends HTMLMaskElement {
   declare input: HTMLElement;
   /** Returns HTMLElement selection start */
-  // @ts-ignore
   override get _unsafeSelectionStart (): number {
     const root = this.rootElement;
     const selection = root.getSelection && root.getSelection();
@@ -19,7 +18,6 @@ class HTMLContenteditableMaskElement extends HTMLMaskElement {
   }
 
   /** Returns HTMLElement selection end */
-  // @ts-ignore
   override get _unsafeSelectionEnd (): number {
     const root = this.rootElement;
     const selection = root.getSelection && root.getSelection();
@@ -47,7 +45,6 @@ class HTMLContenteditableMaskElement extends HTMLMaskElement {
   }
 
   /** HTMLElement value */
-  // @ts-ignore
   override get value (): string {
     return this.input.textContent;
   }

diff --git a/packages/imask/src/controls/html-input-mask-element.ts b/packages/imask/src/controls/html-input-mask-element.ts
@@ -17,13 +17,11 @@ class HTMLInputMaskElement extends HTMLMaskElement {
   }
 
   /** Returns InputElement selection start */
-  // @ts-ignore
   override get _unsafeSelectionStart (): number {
     return this.input.selectionStart;
   }
 
   /** Returns InputElement selection end */
-  // @ts-ignore
   override get _unsafeSelectionEnd (): number {
     return this.input.selectionEnd;
   }
@@ -33,7 +31,6 @@ class HTMLInputMaskElement extends HTMLMaskElement {
     this.input.setSelectionRange(start, end);
   }
 
-  // @ts-ignore
   override get value (): string {
     return this.input.value;
   }

diff --git a/packages/imask/src/controls/html-mask-element.ts b/packages/imask/src/controls/html-mask-element.ts
@@ -4,7 +4,7 @@ import IMask from '../core/holder';
 
 /** Bridge between HTMLElement and {@link Masked} */
 export default
-class HTMLMaskElement extends MaskElement {
+abstract class HTMLMaskElement extends MaskElement {
   /** Mapping between HTMLElement events and mask internal events */
   static EVENTS_MAP = {
     selectionChange: 'keydown',
@@ -17,6 +17,7 @@ class HTMLMaskElement extends MaskElement {
   /** HTMLElement to use mask on */
   declare input: HTMLElement;
   declare _handlers: {[k: string]: EventListener};
+  abstract value: string;
 
   constructor (input: HTMLElement) {
     super();

diff --git a/packages/imask/src/controls/input.ts b/packages/imask/src/controls/input.ts
@@ -354,8 +354,7 @@ class InputMask<Opts extends FactoryArg> {
   /** Unbind view events and removes element reference */
   destroy () {
     this._unbindEvents();
-    // @ts-ignore why not
-    this._listeners.length = 0;
+    (this._listeners as any).length = 0;
     delete this.el;
   }
 }

diff --git a/packages/imask/src/controls/mask-element.ts b/packages/imask/src/controls/mask-element.ts
@@ -12,13 +12,13 @@ type ElementEvent =
 
 /**  Generic element API to use with mask */
 export default
-class MaskElement {
+abstract class MaskElement {
   /** */
-  declare readonly _unsafeSelectionStart: number;
+  abstract get _unsafeSelectionStart(): number;
   /** */
-  declare readonly _unsafeSelectionEnd: number;
+  abstract get _unsafeSelectionEnd(): number;
   /** */
-  declare value: string;
+  abstract value: string;
 
   /** Safely returns selection start */
   get selectionStart (): number {
@@ -54,14 +54,14 @@ class MaskElement {
     } catch {}
   }
 
-  /** Should be overriden in subclasses */
-  _unsafeSelect (start: number, end: number): void {}
-  /** Should be overriden in subclasses */
+  /** */
   get isActive (): boolean { return false; }
-  /** Should be overriden in subclasses */
-  bindEvents (handlers: {[key in ElementEvent]: Function}) {}
-  /** Should be overriden in subclasses */
-  unbindEvents (): void {}
+  /** */
+  abstract _unsafeSelect (start: number, end: number): void;
+  /** */
+  abstract bindEvents (handlers: {[key in ElementEvent]: Function}): void;
+  /** */
+  abstract unbindEvents (): void
 }
 
 

diff --git a/packages/imask/src/masked/base.ts b/packages/imask/src/masked/base.ts
@@ -47,7 +47,7 @@ type MaskedOptions<M extends Masked=Masked, Props extends keyof M=never> = Parti
 
 /** Provides common masking stuff */
 export default
-class Masked<Value=any> {
+abstract class Masked<Value=any> {
   static DEFAULTS: Partial<MaskedOptions> = {
     skipInvalid: true,
   };

diff --git a/packages/imask/src/masked/function.ts b/packages/imask/src/masked/function.ts
@@ -9,6 +9,7 @@ type MaskedFunctionOptions = MaskedOptions<MaskedFunction>;
 export default
 class MaskedFunction<Value=any> extends Masked<Value> {
   declare mask: (value: string, masked: this) => boolean;
+
   override updateOptions (opts: Partial<MaskedFunctionOptions>) {
     super.updateOptions(opts);
   }

diff --git a/packages/vue-imask/src/component3-options.ts b/packages/vue-imask/src/component3-options.ts
@@ -1,4 +1,4 @@
-import IMask, { type FactoryOpts, type InputMask } from 'imask';
+import IMask, { type FactoryOpts } from 'imask';
 import { h, defineComponent, type PropType } from 'vue-demi';
 import props from './props';
 import { extractOptionsFromProps } from './utils';
@@ -89,7 +89,7 @@ export default defineComponent<MaskProps>({
         if (maskOptions.mask) {
           if (this.maskRef) {
             this.maskRef.updateOptions(maskOptions);
-            const [cprop, mprop] = this._getMaskProps();
+            const [cprop] = this._getMaskProps();
 
             if (cprop) this._updateValue();
           } else {