Update feature asyncwebserver and fix network scanning

[ovidiupruteanu]

No description provided.

[tablatronix]

I am rebuilding this branch, to make it mergable from master, without conflicts

[tablatronix]

What particularly did you fix, there is a merge in this PR, or is that all it is?

[ovidiupruteanu]

This branch wasn't working for me, I had the same issue described by @dronecz in issue #1121 . I started by merging master, but that didn't fix the issue.
It is now mergable from master without conflicts. I did my best to test it, and it works for me on ESP8266, but it should be double checked, I was not familiar with the code before starting this.

The change I made that fixed #1121 was to set _asyncScan to true and remove the hardcoded async=true from WiFiManager::WiFi_scanNetworks

[tablatronix]

ok ill check that also, thanks

[ovidiupruteanu]

I tested some more. On ESP8266 it's working with Auto, OnDemand, AutoNonBlocking, OnDemandNonBlocking, NonBlockingwParams.
OTA Update doesn't seem to be working.

I also tested on ESP32 and for some reason it still does a SYNC Scan, I will debug further.

*wm:[2] NUM CLIENTS:  1
*wm:[2] <- Request redirected to captive portal 
*wm:[2] <- HTTP Root 
*wm:[2] WiFi Scan ASYNC started 
*wm:[2] <- HTTP Wifi 
*wm:[2] WiFi Scan SYNC started 
*wm:[0] [ERROR] scan waiting 
*wm:[0] . 
*wm:[0] . 
*wm:[0] . 
.........
*wm:[0] . 
*wm:[0] . 
*wm:[0] . 
E (66893) task_wdt: Task watchdog got triggered. The following tasks did not reset the watchdog in time:
E (66893) task_wdt:  - async_tcp (CPU 0/1)
E (66893) task_wdt: Tasks currently running:
E (66893) task_wdt: CPU 0: IDLE0
E (66893) task_wdt: CPU 1: loopTask
E (66893) task_wdt: Aborting.
abort() was called at PC 0x40139da4 on core 0

ELF file SHA256: 0000000000000000

Backtrace: 0x400887f0:0x3ffbf810 0x40088a6d:0x3ffbf830 0x40139da4:0x3ffbf850 0x40086f2d:0x3ffbf870 0x401562e3:0x3ffbc210 0x4013b73b:0x3ffbc230 0x4008b22d:0x3ffbc250 0x40089a7e:0x3ffbc270

Rebooting...

[tablatronix]

Yeah thats a known issue

#1121

[ovidiupruteanu]

WiFiManager/WiFiManager.cpp

Lines 3698 to 3702 in 7bffda3

	#ifdef WM_DEBUG_LEVEL
	DEBUG_WM(DEBUG_VERBOSE,F("ESP32 event handler enabled"));
	#endif
	using namespace std::placeholders;
	if(wm_event_id !=0) wm_event_id = WiFi.onEvent(std::bind(&WiFiManager::WiFiEvent,this,_1,_2));

I see that wm_event_id != 0 was added to fix #1383 but this seems to cause it to never subscribe to WiFi events. Shouldn't it be wm_event_id == 0? After I changed this async network scanning started working on ESP32.

[tablatronix]

YES

[tablatronix]

483b834

Sorry, been distracted lately, and I didn't test it..

[ovidiupruteanu]

Thanks! This branch now works for both ESP8266 and ESP32.
I am working with AsyncWebServer in my current project. Let me know if you need help with development or testing for this.

[CircuitSetup]

Any plans on merging this?