Added config option max_per_page #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR. We are fine with making these configurable as a server flag. However, we will have to run some benchmarks to understand whether making these parameters a variable ends up disturbing any compiler optimizations that are currently relying on them being static. We're in the last leg of the 0.26 release, so will test and benchmark this change in a few weeks. |
* Added max_per_page in cofig * added default topster size config * removing const default_topster_size * typo fix * Update tests.yml * few test fixes * bug fix * test fix * added couple missing lines * last test fix
* Added max_per_page in cofig * added default topster size config * removing const default_topster_size * typo fix * Update tests.yml * few test fixes * bug fix * test fix * added couple missing lines * last test fix * few fixes after updates from origin
|
Happy to review this now that the v26 release is done. Can you please rebase this PR against the v27 branch? Thank you. |
|
@kishorenc Done |
kishorenc
requested changes
Apr 22, 2024
lukaslau
changed the title
kishorenc
requested changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Added config option max-per-page and default-topster-size to be able to increase max hits count per page.
Configs max-per-page and default-topster-size value should be the same.
PR Checklist
#780