Log source modules that provide most completions #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript can sometimes provide huge number of completions, depending on what modules are installed in the project, and in some editors that can cause performance issues.
For example having
aws-sdkpackage installed in the project can result in additional 70MB of completion data returned from the completion response.This change's purpose is to log those biggest offenders in the LSP communication log so that the user can use that information to potentially ignore completions from that module (using
initializationOptions.preferences.autoImportFileExcludePatterns).This is a bit of a power-user feature since many users will probably not check the LSP communication log. I suppose it might be more useful to have some more user-facing solution for that but not sure how this could be done.