Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't count idle connections against maxTotal #441

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

rossabaker
Copy link
Member

No description provided.

@rossabaker
Copy link
Member Author

We don't need a permit unless we're allocating a resource. When we do, we don't want to release the permit if we're resuing it. bada1fa does the trick, but exposes a different problem: if we're at maxTotal between all the idle connections, we need to release at least one to make room for an acquisition.

Prior art:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant