New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nscplugin, sbt-scala-native to 0.5.1 #4585
Conversation
Seems blocked by typelevel/discipline#446, |
8d98033
to
e383012
Compare
+ Update scalacheck to 1.18.0 |
8e829ea
to
a4068f4
Compare
Ok, the checks are passing now π |
Can we take a pass through the project and remove all the weird stuff we did b/c Scala Native didn't support multi-threading? For example this should no longer be necessary: cats/tests/native/src/test/scala/cats/native/tests/FutureSuite.scala Lines 40 to 41 in dfd9559
Probably we can now share that suite between JVM and Native. Thanks! |
A special synchronous executor for scala-native is no longer needed for FutureSuite as scala-native 0.5.x is multi-threaded. FutureSuite is now shared between JVM and Native.
Wasn't sure if anyone was working on this so I went ahead and opened a PR: #4601 |
Remove special ExecutionContextExecutor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is constantly failing with
[error] Test runner interrupted by fatal signal 11
[warn] Force close java.lang.RuntimeException: Process /home/runner/work/cats/cats/tests/native/target/scala-2.13/cats-tests-test finished with non-zero value 139 (0x8b)
|
||
val disciplineMunitVersion = "2.0.0-M3" | ||
val disciplineMunitVersion = "2.0.0-M4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the meantime there is a 2.0.0 release: https://github.com/typelevel/discipline-munit/releases/tag/v2.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right. However, I think it wouldn't hurt if we address it in a separate PR to avoid stuffing up this one.
It would be perfect, if @typelevel-steward could wake up and create such a PR for us.
About this PR
π¦ Updates
from
0.4.17
to0.5.1
π GitHub Release Notes - Version Diff
Usage
β Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
β Adjust future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: