Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize traverse #4498

Merged
merged 31 commits into from May 1, 2024
Merged

Optimize traverse #4498

merged 31 commits into from May 1, 2024

Commits on Aug 18, 2023

  1. Optimize List traverse for stack-safe Monads

    @TimWSpence
    TimWSpence committed Aug 18, 2023
    Copy the full SHA
    858cca4 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Optimize {List, Vector} traverse for StackSafeMonads

    @TimWSpence
    TimWSpence committed Aug 21, 2023
    Copy the full SHA
    847df54 View commit details
    Browse the repository at this point in the history

  2. Optimize {Queue, Map} traverse for StackSafeMonads

    @TimWSpence
    TimWSpence committed Aug 21, 2023
    Copy the full SHA
    878c4d0 View commit details
    Browse the repository at this point in the history

  3. Optimize Seq traverse for StackSafeMonads

    @TimWSpence
    TimWSpence committed Aug 21, 2023
    Copy the full SHA
    9d86c98 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Optimize ArraySeq traverse for StackSafeMonads

    @TimWSpence
    TimWSpence committed Aug 22, 2023
    Copy the full SHA
    c4bcba2 View commit details
    Browse the repository at this point in the history

  2. Optimize Chain traverse for StackSafeMonads

    @TimWSpence
    TimWSpence committed Aug 22, 2023
    Copy the full SHA
    c4c64ec View commit details
    Browse the repository at this point in the history

  3. Add size hint to StackSafeMonad traverse

    @TimWSpence
    TimWSpence committed Aug 22, 2023
    Copy the full SHA
    1344a70 View commit details
    Browse the repository at this point in the history

  4. Optimize List traverseFilter for StackSafeMonads

    @TimWSpence
    TimWSpence committed Aug 22, 2023
    Copy the full SHA
    b6973dc View commit details
    Browse the repository at this point in the history

  5. Optimize {Seq, Queue, Vector, ArraySeq} traverseFilter for 

    StackSafeMonads
    @TimWSpence
    TimWSpence committed Aug 22, 2023
    Copy the full SHA
    f0648c4 View commit details
    Browse the repository at this point in the history

  6. Optimize Chain filterTraverse for StackSafeMonads

    @TimWSpence
    TimWSpence committed Aug 22, 2023
    Copy the full SHA
    dbccc8e View commit details
    Browse the repository at this point in the history

  7. Optimize List traverse_ for StackSafeMonads

    @TimWSpence
    TimWSpence committed Aug 22, 2023
    Copy the full SHA
    fbf5ea5 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Optimize Vector traverse_ for StackSafeMonads 

    Also fix 2.12 errors
    @TimWSpence
    TimWSpence committed Aug 23, 2023
    Copy the full SHA
    9f60d2b View commit details
    Browse the repository at this point in the history

  2. Optimize {Seq, ArraySeq, Chain, Queue} traverse_ for StackSafeMonads

    @TimWSpence
    TimWSpence committed Aug 23, 2023
    Copy the full SHA
    f4fcf57 View commit details
    Browse the repository at this point in the history

  3. Add extra laws tests so we test the multiple branches corresponding to 

    different runtime types for the Applicative instance
    @TimWSpence
    TimWSpence committed Aug 23, 2023
    Copy the full SHA
    d50bf83 View commit details
    Browse the repository at this point in the history

  4. Add benchmarks for traverse_ and for Chain

    @TimWSpence
    TimWSpence committed Aug 23, 2023
    Copy the full SHA
    5c5049f View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Use .void over .map(_ => ()) to give instances chance to optimize

    @TimWSpence
    TimWSpence committed Aug 25, 2023
    Copy the full SHA
    a1c9ff5 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Experiment: use immutable data structures in optimized traverse 

    Is this necessary? The monad laws should ensure that it's safe to use
mutable builders. Nonetheless it will be good to confirm the performance
delta for using immutable data structures
    @TimWSpence
    TimWSpence committed Nov 8, 2023
    Copy the full SHA
    8cc742e View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Experiment: use immutable List for optimized traverse 

    To see if this is more performant than an immutable vector
    @TimWSpence
    TimWSpence committed Nov 10, 2023
    Copy the full SHA
    e3ae584 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Use applicative methods instead of flatMap 

    For the benefit of Monads with optimized Applicative operations eg
parsers
    @TimWSpence
    TimWSpence committed Nov 14, 2023
    Copy the full SHA
    f95b087 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Experiment: use Chain for aggregating our optimized traverse

    @TimWSpence
    TimWSpence committed Dec 8, 2023
    Copy the full SHA
    c5d90a6 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Implement optimized traverseFilter in terms of Chain as well

    @TimWSpence
    TimWSpence committed Dec 13, 2023
    Copy the full SHA
    2d5f4d7 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Vector-based optimized traverse and traverseFilter in the same commit 

    for the sake of benchmarking
    @TimWSpence
    TimWSpence committed Dec 19, 2023
    Copy the full SHA
    702ab8b View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. Retroactive attempt to establish a baseline including the new benchmarks

    @TimWSpence
    TimWSpence committed Dec 22, 2023
    Copy the full SHA
    b08196e View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Revert "Retroactive attempt to establish a baseline including the new… 

    … benchmarks"

This reverts commit b08196e. We've got
our baseline benchmarks now
    @TimWSpence
    TimWSpence committed Mar 4, 2024
    Copy the full SHA
    92c91e4 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into optimize-traverse

    @TimWSpence
    TimWSpence committed Mar 4, 2024
    Copy the full SHA
    7d615dc View commit details
    Browse the repository at this point in the history

  3. Use Applicative#unit to limit allocations

    @TimWSpence
    TimWSpence committed Mar 4, 2024
    Copy the full SHA
    eebed5b View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. More Applicative#unit to limit allocations

    @TimWSpence
    TimWSpence committed Mar 5, 2024
    Copy the full SHA
    803107d View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Remove mutable builder from Map traverse as its unlawful

    @TimWSpence
    TimWSpence committed Mar 7, 2024
    Copy the full SHA
    0ee49e6 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Use Chain in traverseDirectly

    @valencik
    valencik committed Mar 22, 2024
    Copy the full SHA
    6529be7 View commit details
    Browse the repository at this point in the history

  2. Use toList in seq traverse, not vector

    @valencik
    valencik committed Mar 22, 2024
    Copy the full SHA
    a62ce4c View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Merge pull request #2 from valencik/more-chain 

    Use `Chain` in `traverseDirectly` helpers
    @TimWSpence
    TimWSpence committed Mar 26, 2024
    Copy the full SHA
    6cb787d View commit details
    Browse the repository at this point in the history