Dispatcher: avoid spinning
#4052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durban
commented
Apr 16, 2024
|
|
||
| final case class Finalizer[F[_]](action: F[Unit]) extends Registration[F] | ||
|
|
||
| final case class PoisonPill[F[_]]() extends Registration[F] | ||
| } | ||
|
|
||
| // the signal is just a skolem for the atomic references; we never actually run it |
There was a problem hiding this comment.
This comment probably referred to an older version of the code(?).
durban
commented
Apr 16, 2024
| final case class Running[F[_]](cancel: F[Unit]) extends RegState[F] | ||
| final case class CancelRequested[F[_]](latch: Promise[Unit]) extends RegState[F] |
There was a problem hiding this comment.
Unrelated, but this type param seems unnecessary.
djspiewak
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small internal refactoring of the "new"
Dispatcher.Currently during cancellation there is a racy write/read of
action(a plainvar), and this is resolved by spinning onstateR(anAtomicReference). The idea of this PR is that since we already have anAtomicReference, which we're reading anyway, we can avoid the data race, and thus the spinning, by puttingactioninside theAtomicReference.Besides this, there are 2 very small changes: removing an outdated comment, and an unnecessary type parameter.