WIP: (Experiment) Mutex based synchronous queue #3607
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point, I am sure this will not be merged because of some limitations of the change, but I thought it was worth having it here for future reference.
The implementation has a problem: It requires
Concurrentinstead ofGenConcurrentwhich I am sure breaks MiMa.Also, we also should benchmark to ensure this version is not considerably slower than the current one.
Plus, it is no longer way simpler than the original one.
Anyways, the two first commits of this branch are probably worth merging.
The first one may be added to Daniel's #3606
And I may create another PR for the second one.