Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: Feat parallel routes for challenges pages #1261

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

aadamw
Copy link
Contributor

@aadamw aadamw commented Dec 4, 2023

Description

Breaking change:

  • shared comments no longer have their separate page (/challenge/[slug]/comment/id etc) instead commentId and replyId are in search params

Related Issue

Closes # TODO: find issue

Motivation and Context

How Has This Been Tested?

Screenshots/Video (if applicable):

Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
typehero-og-image ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 8:34pm

Copy link

vercel bot commented Dec 4, 2023

@aadamw is attempting to deploy a commit to the trash company Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Dec 4, 2023

E2E report: https://46b77d62.typehero-70p.pages.dev

@bautistaaa bautistaaa self-requested a review December 9, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant