fix: class-transformer as peer dependency #371
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mareksnincak
reviewed
Nov 3, 2023
| @@ -18,7 +18,8 @@ | |||
| "orm" | |||
| ], | |||
| "peerDependencies": { | |||
| "reflect-metadata": "^0.1.13" | |||
| "reflect-metadata": "^0.1.13", | |||
| "class-transformer": "*" | |||
There was a problem hiding this comment.
Shouldn't class-transformer be moved from dependencies to devDependencies with this change?
There was a problem hiding this comment.
This would be a breaking change as every consumer would be required to provide it's own copy of class-transformer. This only changes the priority :)
|
@whimzyLive can you take a look at this PR? Can confirm this resolves the issue I brought up in #341 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marks class-transformer as peer dependency next to dependency. This ensures consumer installed version is prioritized and used to avoid runtime issues.
Resolves: #341, #365