Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate attribute name check for indexes #362

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pokermanx
Copy link

Since DynamoDB allows to have multiple indexes with duplicate column names this check is not needed.

@whimzyLive
Copy link
Member

@pokermanx Thanks for raise this PR.

Can you provide more information on why is this required? i.e an example scenario?

Thanks

@pokermanx
Copy link
Author

hey, sorry for delayed response.

Example: A table that has 2 indexes that share a column. One index has pk as userName and sk status, other one has pk as userEmail and sk status. Setting indexes as

UserNameIndex: {
  type: INDEX_TYPE.GSI,
  partitionKey: 'userName',
  sortKey: 'status',
},
UserEmailIndex: {
  type: INDEX_TYPE.GSI,
  partitionKey: 'userEmail',
  sortKey: 'status',
}

will throw a Failed to parse entity error

@eulerchavez
Copy link

Hi!

Is there any status for this feature?

@whimzyLive

@reestolonio
Copy link

I'm having the same issue and was forced to create new columns unique for each index.

@dremonkey
Copy link

dremonkey commented Mar 6, 2024

Having the same issue. And agree that this check is unnecessary. DynamoDB supports the above index config without any issues.

@seriousjelly
Copy link

Any updates here? Having the same issue having shared columns... It's been open for a while now, any updates on when this can be merged in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants