Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

class-trasnsformer should be a peer dependency #341

Open
nVitius opened this issue Apr 19, 2023 · 1 comment · May be fixed by #371
Open

class-trasnsformer should be a peer dependency #341

nVitius opened this issue Apr 19, 2023 · 1 comment · May be fixed by #371

Comments

@nVitius
Copy link

nVitius commented Apr 19, 2023

I just ran into an issue where my version of class-transformer was different than the one that typedorm depends on.
This was causing the decorators I imported from class-transformer to not worked as expected. To avoid the possibility of conflicting versions, this should be in peerDependencies instead of dependencies.
@GTRanger
Copy link

I've run into this issue in the past as well. This would be an excellent change.

@mareksnincak mareksnincak mentioned this issue Oct 9, 2023
Open
@Michsior14 Michsior14 linked a pull request Oct 26, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: class-transformer as peer dependency Michsior14/typedorm
2 participants
@nVitius @GTRanger