Allow Bluebird to be assignable to es2016 standard Promise:

[Strate]

Add overload for 2-argument .then call.

see DefinitelyTyped/DefinitelyTyped#11027

[blakeembrey]

@Strate Could you correct the changes to the comment block?

[Strate]

@blakeembrey in what case? Just a fix argument names or split comment into four, as in standard Promise?

[Strate]

aught, there is CI issues, I'll fix it now.

[blakeembrey]

Sorry, correcting the changes just meant to remove the unnecessary change in the comment block (which did result in a linting failure).

[Strate]

@blakeembrey, what do you think to implement PromiseLike, or even stabdard Promise interface on Bluebird class, to avoid such issues in the future?

[blakeembrey]

@Strate It's implemented as Bluebird.Thenable, which reminds me that perhaps that also should be updated.

[Strate]

interface Thenable<R> extends PromiseLike<R>;

And remove .then from Promise class completely.

[Strate]

And remove .then from Promise class completely.

nvm, we should add overrides to change return type of .then

[blakeembrey]

@Strate I might actually have to test this repo out a little, but unless I'm missing something, isn't it odd that the tests passed before? Since Bluebird implements Thenable was working, doesn't that make the changes assignable already?

[Strate]

@blakeembrey nope, because issue was: "bluebird is not assignable to es6 promise", not "es6 promise is not assignable to bluebird".
For example, if I would change Thenable to correspond PromiseLike, but not change Bluebird to correspong Promise: Bluebird imlements Thenable would be broken.

[blakeembrey]

Ah, this is a huge PITA. This change actually breaks anyone using TypeScript < beta. I just run into it, can't use async/await since the then implementation is different. Not sure if this issue has been resolved on TypeScript, or future changes can still break this.

[blakeembrey]

Interestingly, the definition I've always used in https://github.com/types/npm-es6-promise/blob/master/dist/es6-promise.d.ts for .then works in both 1.8 and 2.0. Can anyone else confirm this or am I going crazy?

[Strate]

@blakeembrey is that definition assignable to es6 promise from ts 2.0? I don't think so...

[blakeembrey]

Yes, it is. I tested it, I was just asking for confirmation. At least, I'm using it with 2.0 through thenify, bcrypt-then.