Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix attachment handle #1696

Merged
merged 3 commits into from
Jan 9, 2024
Merged

fix attachment handle #1696

merged 3 commits into from
Jan 9, 2024

Conversation

joyqi
Copy link
Member

@joyqi joyqi commented Jan 8, 2024

fix #1694

@joyqi joyqi requested a review from sy-records January 9, 2024 04:53
Comment on lines 327 to 329
if ($current) {
break;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还是一样的,还是个索引

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确实,我觉得再加一个方法单独处理比较合适,因为有的返回不是 Array 了

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以

@joyqi joyqi requested a review from sy-records January 9, 2024 06:20
@joyqi joyqi merged commit 7115a30 into master Jan 9, 2024
5 checks passed
@sy-records sy-records deleted the fix/attachment_handle branch January 9, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.3.0-alpha 无法从文件系统中删除文件
2 participants