Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ssl for pdo_mysql and mysqli #1525

Merged
merged 4 commits into from
Mar 29, 2023
Merged

Support ssl for pdo_mysql and mysqli #1525

merged 4 commits into from
Mar 29, 2023

Conversation

sy-records
Copy link
Member

支持了一下简版的ssl,测试planetscale通过。

腾讯云的云db,开启ssl以后连接使用证书,需要关闭验证,那开启ssl意义好像就没了 😅

Peer certificate CN=`TencentDB ROOT SERVER-CA' did not match expected CN...

Close #1508

@sy-records sy-records requested a review from joyqi January 16, 2023 00:11
@ancientcatz
Copy link

Does it really work?

@sy-records
Copy link
Member Author

I've tested planetscale and Tencent Cloud

@hurui200320
Copy link

Tested with Linode's managed database, and it's working.

@joyqi Can we have this patch in 1.2.1?

@joyqi
Copy link
Member

joyqi commented Mar 28, 2023

@sy-records @hurui200320 I've made some enhancements for this issue, and I think we should validate it for both Pdo_Mysql and Mysqli.

@hurui200320
Copy link

I tested the Pdo_Mysql. Today I was migrating from my local MySQL to Linode's managed MySQL and eventually find this pr. I applied the changes to the latest 1.2.1-rc code and it's working properly.

(Yes, I did that in production env, LOL)

@sy-records
Copy link
Member Author

@joyqi I tested it and it's ok for me

@joyqi joyqi merged commit daef17d into master Mar 29, 2023
6 checks passed
@joyqi joyqi deleted the ssl branch March 29, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typecho连接云数据库出错
4 participants