Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a prompt message for manual database creation #1348

Merged
merged 3 commits into from
May 16, 2023
Merged

Conversation

sy-records
Copy link
Member

@sy-records sy-records commented Mar 28, 2022

close #1338
close #1520

Copy link
Member

@joyqi joyqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

将在下一个版本中合并

@joyqi
Copy link
Member

joyqi commented May 16, 2023

我还是觉得不应该由程序来创建数据库,这是一个高权限的操作,修改了代码以后实际上允许typecho在不选择数据库的情况下运行,这可能带来更多的问题,也与我们的设计原则相悖。我觉得倒是可以加一个更友好的提示,让用户知道需要自己去创建数据库。

@sy-records sy-records marked this pull request as draft May 16, 2023 05:03
@sy-records sy-records self-assigned this May 16, 2023
@sy-records sy-records marked this pull request as ready for review May 16, 2023 06:25
@sy-records sy-records requested a review from joyqi May 16, 2023 06:25
@sy-records sy-records changed the title Optimize for no database during install Add a prompt message for manual database creation May 16, 2023
@joyqi joyqi merged commit c725fec into typecho:master May 16, 2023
6 checks passed
@sy-records sy-records deleted the install branch May 16, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

master 分支代码直接用于初始化不会自动创建数据库(可能是bug?) 细分 MySQL 报错
2 participants