Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

Add releasing docs for python artifacts (jobclient, sidecar, cli) #2066

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

scrosby
Copy link
Member

@scrosby scrosby commented Apr 12, 2022

Changes proposed in this PR

  • Update documenttaion on how to release python artifacts.

Why are we making these changes?

Make it easier to know how to release Cook.

```
Then, in a separate virtualenv for testing:
```bash
pip3 install --index-url https://test.pypi.org/simple/ --no-deps cook-executor==$VERSION
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI is cook-client

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this is a few places in this file, btw)

```
Then, in a separate virtualenv for testing:
```bash
pip3 install --index-url https://test.pypi.org/simple/ --no-deps cook-executor==$VERSION
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this is a few places in this file, btw)

Then, in a separate virtualenv for testing:
```bash
pip3 install --index-url https://test.pypi.org/simple/ --no-deps cook-executor==$VERSION
pip3 install # install any other required dependencies from the main pypi repo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part was confusing to me. I ended up installing cook-client
pip3 install cook-client
and then using the full path to the cs in my virtual env. Is that what you meant?

@@ -0,0 +1,41 @@
Releasing Cook Executor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file still says executor in some places

```
Then, in a separate virtualenv for testing:
```bash
pip3 install --index-url https://test.pypi.org/simple/ --no-deps cook-executor==$VERSION
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cook-sidecar, not cook-executor

Since PyPI does not allow modifying releases, it can be useful to test a release using their test instance.
```bash
rm -rf dist/*
python3 setup.py sdist bdist_wheel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is worth mentioning or if this is just some Python distribution basics that I missed, but bdist_wheel isn‘t available unless you pip install wheel

Releasing Cook Executor
=======================

Cook Sidecar is released on [PyPI](https://pypi.org/project/cook-executor/)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cook-sidecar, not cook-executor

-------------
Ensure you can build the sidecar following the instructions in README.md

Install `twine`:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also install wheel to be able to bdist_wheel

Releasing Cook Executor
=======================

Cook's Jobclient API is released on [PyPI](https://pypi.org/project/cook-executor/)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cook-client-api, not cook-executor

-------------
Ensure you can build the cli following the instructions in README.md

Install `twine`:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also install wheel to be able to bdist_wheel

-------------
Ensure you can build it following the instructions in README.md

Install `twine`:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also install wheel to be able to bdist_wheel

@scrosby scrosby force-pushed the outgoing/python-release-docs branch from 12affa1 to 1f3330f Compare July 27, 2022 00:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants